AWS CloudFormation Linter

Calling garbage collector manually does not necessarily improve performanceCS-P1001 Audit required: Switch to a better crypto algorithmCS-A1002 Avoid empty finalizersCS-P1000 Consider using `Environment.ProcessId` instead of `Process.GetCurrentProcess().Id`CS-P1002 Async methods should not have a return type of `void`CS-R1005 Non-Async methods with return type `Task/Task<T>` should not return `null`CS-R1006 Use `Guid.Empty` to create an empty GUIDCS-R1007 `ToString` method should never return `null`CS-R1011 Potential memory leak inside `for` loop due to `stackalloc`CS-W1025 Binary Formatter deserializes data in an insecure manner and should not be usedCS-S1006 Audit required: Insecurely generated random numberCS-A1008 Audit required: Cookie is transmitted over an insecure connectionCS-A1009 Audit required: Cookie is accessible through a client-side scriptCS-A1010 Use `double.IsNaN()` to check if a `double` is `NaN`CS-W1003 Audit required: `enum` used for permissions is missing the `Flags` attributeCS-A1004 Use the `is` operator to simplify type checkCS-R1049 Filesystem related permissions specified are too broadCS-S1000 Consider specifying the full path to the executable file when spawning processesCS-S1002 Implementing custom crypto algorithms is not secureCS-S1005 Empty interpolated stringCS-W1000 Usage of deprecated `Thread`ing APIsCS-W1002 `Equals` and `GetHashCode` must be overridden in pairCS-W1006 Possible `IndexOutOfRangeException` whilst iteratingCS-W1007 Comparison operator has same operands on both sidesCS-W1026 Assignment expression found in place of conditionCS-W1032 Using `throw ex` resets the Exception's stack traceCS-W1038 Incorrectly formatted stringCS-W1024 `ICloneable` does not define a spec for `Clone()` and hence should not be implementedCS-R1104 Conditional branch has the same expression in both the branchesCS-W1073 Incorrect variable being modified in nested loopsCS-W1074 Casting a `object[]` to `string[]` will result in `CastException`CS-W1075 Empty `lock` statements should be avoidedCS-W1076 Empty `if` statements should be avoidedCS-W1077 Getters and setters should be mutually synchronizedCS-W1078 Operator implementation refers to itself and may cause recursive callsCS-W1079 Use `ContainsKey()` to check if a key exists in a `Dictionary<T, K>`CS-P1016 Result of the bitwise operation is same as its operandCS-R1089 Anti-forgery token is ignored via `IgnoreAntiforgeryTokenAttribute`CS-A1011 Consider using `Uri.EscapeDataString()` instead of `Uri.EscapeUriString()`CS-S1009 Number of elements passed instead of buffer lengthCS-W1051 Do not declare finalizers for types derived from `MemoryManager<T>`CS-W1052 Pointer is being compared with `null`CS-W1063 Unary operator is redundant due to its operandCS-R1090 Insecure protocol specified for `ServicePointManager`CS-S1007 Unary `is` expression can be simplifiedCS-R1094 Consider using more appropriate overload `StringBuilder.Append(char)`CS-P1017 Consider using `typeof(T).Assembly` to get currently executing assemblyCS-P1018 Null conditional operator is made redundant by a dominant checkCS-R1087 `ThreadStatic` attribute used on a field that has explicit valueCS-R1088 Method is empty and effectively does nothingCS-R1093 Security attribute is ineffective due to parent scope's attributeCS-S1008 `GetType()` called on `System.Type`CS-W1064 Consider moving to safer and recommended alternatives as the web APIs used are obsoleteCS-S1010 Insecure SQL authentication specifiedCS-S1011 Specified certificate validation callback is insecureCS-S1012 Consider explicitly specifying the `XmlResolver` propertyCS-S1013 Wildcard domains being listened to by `HttpListener`CS-S1014 Incorrect block delimitationCS-S1015 `DisableRequestSizeLimitAttribute` attribute used to disable request body's size limitsCS-S1016 User input being processed directly without sanitizationCS-S1017 Lock is obtained on a `public` `object`CS-W1046 `GetHashCode()` relies on a mutable entityCS-W1048 `enum` marked with `Flags` attribute is missing required initializationCS-W1049 `StringBuilder` is initialized with an invalid argumentCS-W1050 Value types should not be compared using `object.ReferenceEquals()`CS-W1053 Result of `IsInstanceOfType()` may be unreliable as an incorrect argument is passedCS-W1065 `Dictionary<T, K>` has duplicate key(s) in its initializerCS-W1054 Argument passed to `Enum.HasFlag` should be same as the type on which it is being invokedCS-W1055 Applying `ThreadStatic` to instance fields is redundantCS-W1056 Do not expose unmanaged resourcesCS-W1057 Exception thrown is obsolete and is no longer in use by the runtimeCS-W1058 Throwing exceptions in `finally` block may affect resource cleanup and stack traceCS-W1060 Classes and structs should be declared within a `namespace`CS-W1061 A disposable entity is being returnedCS-W1062 Missing implementation of members wrapped in an interface attributed with `DynamicInterfaceCastableImplementation`CS-W1066 Incorrect `TaskCompletionSource` constructor invokedCS-W1067 Result of a pure method is unusedCS-W1068 Methods should pass optional parameters to the base implementationCS-W1071 Comparing an entity's type against `typeof(Nullable<T>)` is unreliableCS-W1069 Empty record achieves nothing and is likely a bad design patternCS-R1134 Detected the use of arithmetic operation to construct a `DateTime` objectCS-W1080 Values in an `enum` should be uniqueCS-W1088 Result of an assignment expression is unusedCS-W1082 Setter does not access `value`CS-W1083 Division by zero results in `System.DivideByZeroException`CS-W1081 Checking for overflow has been skippedCS-W1087 Avoid inheriting outdated typesCS-R1115 If-else chain has a duplicate conditionCS-W1084 `static` field is hidden due to method's parameterCS-W1085 Argument passed to `Equals()` is same as the object upon which this method is invokedCS-W1086 Object is passed to a method that belongs to itselfCS-W1098 Missing `Culture`-related information when parsing `Date` and `Time`-sCS-W1092 `Length`-like property is compared against values which always evaluate to the same resultCS-W1090 Found the usage of `DateTime.Now` that relies on system-specific informationCS-W1091 `IEnumerable.Skip()` takes in number of elements to skip rather than the indexCS-W1093 Acquiring `lock` on local variables is error-proneCS-W1094 Object created is neither assigned to a variable nor passed as an argument but is dropped immediatelyCS-W1097 Getter and setter should access the same fieldsCS-W1095 Oddness test is broken for negative numbersCS-W1089 Properties should not return arrays as they are not write protectedCS-W1096 Parameters marked as `in`, `out` or `ref` should always be placed after all the required parametersCS-R1138 `null` literal explicitly passed to `??` operatorCS-R1135 Missing `Justification` value in `SuppressMessage` attributeCS-R1139 Getters must not throw exceptionsCS-R1038 Explicit trap of `NullReferenceException`CS-R1009 Audit required: Call to potentially dangerous method `DangerousGetHandle`CS-A1001 Audit: Consider using `System.URI` instead of `string`sCS-A1000 Consider making `static readonly` fields `const`CS-P1003 Do not overload the `==` operator to perform value equality checksCS-R1001 Methods with `Pure` attribute should return a valueCS-R1002 Methods with `DoesNotReturn` attribute should not return a valueCS-R1003 Consider using `.TryParse` over `.Parse` when converting typesCS-R1004 Exception caught is genericCS-R1008 Accessor like method has return type `void`CS-R1013 Use `string.IsNullOrEmpty` or `string.IsNullOrWhiteSpace` to check for empty stringsCS-R1014 Exception thrown is genericCS-R1015 Obsolete attribute should specify the messageCS-R1016 Redundant call to `ToCharArray()` when iterating a stringCS-P1004 Empty `default` label without a comment is redundantCS-R1022 Method marked as `TestMethod` declared in a non-test classCS-W1013 Consider having 1 `public` class per namespaceCS-R1035 Consider using the appropriate overloaded method when searching for a single charCS-P1006 Audit required: Instance of `NotImplementedException`CS-A1003 Audit required: Warning disabled explicitlyCS-A1006 Abrupt application exitCS-W1005 `var` is redundant when combined with `out` and a discard patternCS-R1067 Consider using `L` as a suffix for `long` rather than `l`CS-R1027 Consider declaring only 1 `namespace` per fileCS-R1034 Deprecated method being invokedCS-W1023 Consider using the constants from the `Math` classCS-R1071 Using negative array indices results in `IndexOutOfRangeException`CS-W1042 Audit required: Test is ignoredCS-A1005 Exceptions that are created must be usedCS-W1043 Unreachable code detectedCS-W1016 Avoid chaining of index lookup and `.Substring` methodCS-P1007 Explicit mention of array type and/or size is redundant when array is initializedCS-R1045 Empty initializer is redundantCS-R1063 Type name contains only lower-cased ASCII charactersCS-W1036 Consider using `.TryGetValue` to access elements in `Dictionary`CS-P1005 Consider using the range operator `..` over `Substring`CS-R1037 Consider rewriting chained `.OrderBy()` calls as `.ThenBy()`CS-P1008 Use `Array.Empty<T>()` to efficiently create empty arraysCS-P1009 Rewrite `virtual void Finalize()` as `~Destructor()`CS-P1010 Use the method overload that accepts `Span<T>` instead of `T[]` when possible to reduce allocationsCS-P1011 Use `StringComparison.OrdinalIgnoreCase` for case insensitive comparisonsCS-R1017 Consider specifying the `CultureInfo` parameter when possibleCS-R1018 Consider simplifying the element accessCS-R1019 Consider returning an empty array instead of `null`CS-R1020 Catch clauses that simply re`throw` Exceptions are redundantCS-R1021 Pure methods cannot have return type `void`CS-R1023 Overridden methods cannot simply call `base` class implementationCS-R1025 `ref` / `out` parameters cannot be marked as `Optional`CS-R1026 Explicit `default` constructors are redundantCS-R1028 `TestMethods` must contain `Assert` statementsCS-R1029 Usage of reserved keywords as variable identifierCS-R1030 Consider simplifying the boolean comparison expression for concisionCS-R1031 Consider inverting the predicate to simplify `!Any()` callCS-R1033 Widening of `Exception` in the catch clauseCS-R1036 `if` conditions can be mergedCS-R1039 Consider collapsing the `null` checkCS-R1040 Consider using `Any()` to check for emptinessCS-R1032 Boolean expression with ternary operator can be simplifiedCS-R1042 `null` check is redundant when used in combination with `is`CS-R1043 Redundant `else` due to `return`CS-R1044 Consider simplifying LINQ query by dropping explicit `.Where()` callCS-R1046 Consider rewriting `Nullable<T>` as `T?`CS-R1047 Consider rewriting `using` statement as `using` declarationCS-R1050 Sorting expression can be simplifiedCS-R1051 Explicitly inheriting `System.Object` and `int` for `class`es and `enum`s is redundantCS-R1052 Classes implementing `IEquatable<T>` can be `sealed`CS-R1053 Class implements `Equals` but not `IEquatable<T>`CS-R1054 Consider rewriting null checks and casts using pattern matchingCS-R1056 Comparing unconstrained generic parameter against `null` is bug-proneCS-R1057 `sealed` modifier for a method in a `sealed` class is redundantCS-R1058 Use `nameof` operator instead of explicitly spelling out the parameterCS-R1059 Consider changing explicit getter and setter to auto-propertyCS-R1060 Consider adding the `init` accessorCS-R1061 Use File Scoped `namespace`s instead of typical `namespace`sCS-R1062 Type can be dropped from the declaration's RHS when explicitly mentioned in the LHSCS-R1064 `unsafe` block is redundant when placed in a method marked as `unsafe`CS-R1065 `protected` field in a `sealed` class is redundantCS-R1066 Lambda can be converted to a method groupCS-R1068 Consider using the appropriate `Console.WriteLine()` overloadCS-R1070 Discard patterns are redundant when used with the `is` operator and can be droppedCS-R1069 You can drop the lower bound in a range expression if is zeroCS-R1072 Insecure protocol specified in clear textCS-S1001 Consider using SSL when dealing with SMTPCS-S1003 Use `Path.GetTempFileName()` to generate unique filenames rather than relying on `DateTime`CS-S1004 Custom `Exception`s should always be `public`CS-W1004 Do not throw from critical methodsCS-W1008 Switch statement is missing the `default` caseCS-W1009 `IndexOf()` like methods operate on 0-based indexingCS-W1010 Test method does not match the required signatureCS-W1011 Use of Yoda expressionsCS-W1012 Calling `Dispose` twice is UBCS-W1014 `enum` with `Flags` attribute has invalid valuesCS-W1015 Non-short circuit logic is likely a mistakeCS-W1017 Use `DateTime.Compare()` to compare `DateTime`sCS-W1018 Potential `NullReferenceException` when comparing against `null`CS-W1019 `.ToString` on an array does not stringify its contentsCS-W1020 Built-in entity shadowed by a declarationCS-W1021 Variable is uninitializedCS-W1022 Variable is assigned to itselfCS-W1027 `null` is being assigned to an entity that is non-nullableCS-W1028 Method has non-nullable return type but returns `null`CS-W1029 Override `GetHashCode` and `Equals` if operators `==` and `!=` are overloadedCS-W1031 Method marked as `extern` is missing relevant attributeCS-W1033 Unused `goto` labelCS-W1034 Method's generic parameter shadows class' generic parameterCS-W1035 Program may not contain an `async` entrypoint when a `sync` entry point existsCS-W1037 Entity marked for `export` is missing its implementationCS-W1039 Constructors should initialize non-null fields when exitingCS-W1040 `Stream.Read()` return value should always be checkedCS-W1041 Consider using the `null-coalescing` operator to simplify the `null` checkCS-R1024 Local declaration shadows class fields and propertiesCS-W1030 Implementing `IComparable<T>` may be particularly usefulCS-R1106 Consider reusing existing instances of `StringBuilder`CS-P1020 Child and parent classes cannot share the same nameCS-R1103 Variable declared when catching `Exception` is unusedCS-R1084 `DefaultParameterValue` must be used instead of `DefaultValue` when `Optional` attribute is specifiedCS-W1045 Consider simplifying lambda when its body has a single statementCS-R1085 `if` statement can be rewritten using the ternary operatorCS-R1105 Use `Environment.ProcessId` to fetch process ID instead of `Process.GetCurrentProcess().Id`CS-P1012 Use `Environment.ProcessPath` to fetch process path instead of `Process.GetCurrentProcess().MainModule.FileName`CS-P1013 Audit: Writing to a file that's in a publicly accessible directoryCS-A1012 Audit required: Pointer arithmetic may point to incorrect memory locationCS-A1013 Audit required: Path used in archive extraction maybe unsanitizedCS-A1014 Use `Environment.CurrentManagedThreadId` to fetch the thread ID instead of `Thread.CurrentThread.ManagedThreadId`CS-P1014 Empty `namespace`s are redundantCS-R1083 Getters and setters with a single statement in their bodies can be simplifiedCS-R1095 Passing an identity function to `Select()` is redundantCS-P1015 Methods that deal with `async` should have their names suffixed with `Async`CS-R1073 `DefaultParameterValue` attribute is redundant when parameter is not marked as `Optional`CS-R1074 `Attribute` suffix is redundant when using an attributeCS-R1075 Use underscores to make long numeric literals readableCS-R1076 Rewrite `new System.Type[0]` as `Type.EmptyTypes`CS-R1077 `abstract` classes with only `abstract` methods should be declared as `interface`sCS-R1078 Replace `string.Compare()` with `string.Equals()`CS-R1079 Reserving a member in an `enum` provides no benefitCS-R1080 Consider using `ThrowIfCancellation()` where possibleCS-R1081 Reserved `Exception` being thrownCS-R1082 `CompilerGenerated` attribute should not be used within user defined codeCS-R1086 Empty `finally` block is redundantCS-R1091 Comparing against a value and assigning the same value is redundantCS-R1092 `abstract` classes cannot contain `public` constructorsCS-R1096 Consider using the `default` literal over `default(T)`CS-R1097 Incorrectly placed typecheckCS-R1098 Redundant call to base class' constructorCS-R1099 Classes that inherit `EventArgs` should be named appropriatelyCS-R1102 Lock is obtained on an entity that does not guarantee reliable mutual exclusionCS-W1044 An `async` method should have at least a single `await`ableCS-W1047 Method exposed by an unmanaged dynamic-link library (DLL) is `public`CS-W1059 Field that was initialized inline is being overwritten in the constructorCS-W1072 Do not prefix enum members with enum's nameCS-R1132 Using the logical not operator to invert binary expressions can affect readabilityCS-R1108 Missing implementation of `System.Exception`CS-R1109 Drop record's body if it does not define any membersCS-R1130 Use `.TryAdd` to safely add keys to a `Dictionary<K, V`>CS-R1123 Consider replacing an `if` statement with just the condition if all it does is return a `bool` valueCS-R1126 Consider reusing `record` objects that rely on `const` parametersCS-P1022 Consider using `Clear()` to set the items in a `Span<T>` to their default valuesCS-P1023 Consider using `not null` instead of an empty recursive pattern when checking for nullnessCS-R1120 Consider using the equality operators when evaluating `bool?`CS-R1118 Unusual data type specified for `enum`CS-P1021 Consider dropping the parameter's name if it is same as the value when instantiating an anonymous objectCS-R1127 Empty `else` statement is redundantCS-R1129 Avoid nested ternary expressionsCS-R1114 A `switch` statement having only a `default` case is redundantCS-R1124 Consider using the indexer when adding a key to `Dictionary<K, V>`CS-R1119 Duplicate `using` directives can be removedCS-R1122 Switch statement is empty and effectively redundantCS-R1117 Explicitly defined `case` labels are redundant if they fallthrough to `default` caseCS-R1107 Consider using `string.Contains` instead of comparing the result of `string.IndexOf`CS-R1110 Comment is empty and adds no contextCS-R1111 Extension method is defined on `object` rather than a specific typeCS-R1112 Missing space between `=` and subsequent operatorCS-R1113 `default` case should always occur at last in a `switch` statementCS-R1121 Comparing an instantiated object with `null` will always evaluate to `false`CS-R1125 Using inefficient methods `Min()`/`Max()` on `SortedSet<T>`CS-P1025 Fields initialized only in constructors can be made `readonly`CS-R1137 Avoid multiple assignments in a single expressionCS-R1143 `0` should be assigned to `None` in `enum`-s attributed with `Flags` attributeCS-R1144 Consider passing `DateTimeKind` when possibleCS-W1099 Use conditional access operator or pattern matching to safely access nullable valueCS-R1136 Properties should not return collections' cloneCS-P1026 Consider dropping redundant call to `HashSet<T>::Contains()`CS-R1142 Using inefficient methods `First()`/`Last()` on `LinkedList<T>`CS-P1024 Use of `TODO/FIXME` comment encounteredCS-D1000 Consider discarding empty blocksCS-R1012 Use aliases when using built-in typesCS-R1000 Names of interfaces must begin with `I`CS-R1010 Use brace initialization when creating a new object and setting its propertiesCS-R1048 Redundant `new` keyword for arrays initialized in placeCS-R1055 Nested switch statementsCS-W1001 Convert complex expression to compound assignmentCS-R1100 Custom attribute is missing `AttributeUsage` attributeCS-W1070 `DefaultConnectionLimit` is set to a value that may degrade performanceCS-P1019 Consider dropping attribute's parenthesisCS-R1101 Numeric literal has incorrect groupingCS-R1131 Deconstruct tuple expression to avoid repetitivenessCS-R1133 Consider using `if`-`else` instead of a `switch` statement when having 2 or fewer casesCS-R1116 `CancellationToken` parameter should always be placed last in the parameter listCS-R1141 Function with cyclomatic complexity higher than thresholdCS-R1140

C#

Static Analysis, SAST, Code Coverage, Code Complexity

Sample Configuration

.deepsource.toml

version = 1

[[analyzers]]
name = "csharp"

Explore the docs for all configuration options.